Add "Orient" trait for Polygon #108
Conversation
|
Could I get a review of this, if someone's got time? |
src/algorithm/orient.rs
Outdated
| /// and its inner ring(s) oriented clockwise. Selecting `Reversed` will result in a Polygon | ||
| /// with a clockwise-oriented exterior ring, and counter-clockwise interior ring(s) | ||
| #[derive(Debug)] | ||
| pub enum Direction { |
There was a problem hiding this comment.
If you added #[derive(Copy, Clone, Debug)] here, you wouldn't need to pass &Direction references everywhere since it's just as cheap to pass the enum value than it is to pass a reference to the enum value.
src/algorithm/orient.rs
Outdated
| pub enum Direction { | ||
| Default, | ||
| Reversed, | ||
| } |
There was a problem hiding this comment.
Might be good to explicitly mention:
enum Direction {
/// exterior ring is oriented counter-clockwise, interior rings are oriented clockwise
Default,
/// exterior ring is oriented clockwise, interior rings are oriented counter-clockwise
Reversed,
}
Sorry about that, this PR slipped by me. Feel free to ping me directly if you need a review for GeoRust things. I also just realized you aren't part of the GeoRust GitHub organization, sorry about that! Just added you. r=me after my couple minor comments (you should be able to add a comment |
|
bors r- no bors, stop, not yet |
Canceled |
|
Unrelated to this PR, I've been working on a geospatial data viewer. My next steps are to add a basic UI and add in some of the operations/algorithms you've implemented in this repository, so thanks for all your work here :) |
|
bors r=frewsxcv |
Build succeeded |
This returns a correctly-oriented copy of the polygon;
Defaultreturns counter-clockwise exterior rings and clockwise interior rings.Reversedreturns rings with the opposite orientation.