Implement Point to multipart geometry distance methods #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frewsxcv
reviewed
Mar 17, 2017
src/algorithm/distance.rs
Outdated
| impl<T> Distance<T, MultiPolygon<T>> for Point<T> | ||
| where T: Float | ||
| { | ||
| fn distance(&self, mpolygon: &MultiPolygon<T>) -> T { |
There was a problem hiding this comment.
I think if you did:
/// Minimum distance from a Point to a MultiPolygon
fn distance(&self, mpolygon: &MultiPolygon<T>) -> T {It would show up in documentation (via rustdoc), just to be explicit about the behavior here.
frewsxcv
reviewed
Mar 18, 2017
src/algorithm/distance.rs
Outdated
| @@ -167,7 +168,8 @@ impl<T> Distance<T, Polygon<T>> for Point<T> | |||
| // Minimum distance from a Point to a MultiPolygon | |||
| impl<T> Distance<T, MultiPolygon<T>> for Point<T> | |||
| where T: Float | |||
| { | |||
| { | |||
frewsxcv
reviewed
Mar 18, 2017
src/algorithm/distance.rs
Outdated
| @@ -180,7 +182,8 @@ impl<T> Distance<T, MultiPolygon<T>> for Point<T> | |||
| // Minimum distance from a Point to a MultiLineString | |||
| impl<T> Distance<T, MultiLineString<T>> for Point<T> | |||
| where T: Float | |||
| { | |||
| { | |||
|
LGTM after whitespace is addressed |
|
bors r+ |
ghost
pushed a commit
that referenced
this pull request
Mar 18, 2017
104: Implement Point to multipart geometry distance methods r=frewsxcv
This adds distance methods and tests from Point to:
- MultiPoint
- MultiLineString
- MultiPolygon
For large MultiPolygons in particular, this could potentially be very slow. One approach would be the use of a spatial index storing the Polygon BoundingBoxes. Retrieving the closest one to the point, then calculating Point-to-Polygon distance would be much faster. There are a number of {quad-, r-, n-}tree implementations around in various states of maintenance, e.g. [acacia](https://github.com/aepsil0n/acacia), or (much heavier, extensively tested) [Spade](https://stoeoef.github.io/spade/spade/struct.RTree.html), so it'd be mostly a case of gluing things together.
(It might also be good to have a spatial index crate backed by one of those implementations in geo-rust, but that's a separate issue)
Build succeeded |
ghost
merged commit 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds distance methods and tests from Point to:
For large MultiPolygons in particular, this could potentially be very slow. One approach would be the use of a spatial index storing the Polygon BoundingBoxes. Retrieving the closest one to the point, then calculating Point-to-Polygon distance would be much faster. There are a number of {quad-, r-, n-}tree implementations around in various states of maintenance, e.g. acacia, or (much heavier, extensively tested) Spade, so it'd be mostly a case of gluing things together.
(It might also be good to have a spatial index crate backed by one of those implementations in geo-rust, but that's a separate issue)