-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use geometry::*
to concisely include all the geometry variants
#853
Conversation
@@ -49,7 +46,7 @@ use num_traits::Float; | |||
/// ``` | |||
pub trait ChamberlainDuquetteArea<T> | |||
where | |||
T: Float + CoordNum, | |||
T: CoordFloat, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These CoordFloat changes are an unrelated no-op cleanup. I just prefer to uniformly reference our internal types over the num_types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sgtm!
8e0e50e
to
1ead56e
Compare
bors r=frewsxcv (rebased) |
Build succeeded: |
CHANGES.md
if knowledge of this change could be valuable to users.Fixes #831 - an ergonomics issue.
So you can now:
And similarly with geo:
(quoting from #831):
Note that I diverged slightly from my original plan in #831.
I initially sought to introduce a new
geometries
module, but then I was afraid it'd be too confusing to have both ageometry
and ageometries
module, so opted instead to have ageometry
module which, as well as defining theGeometry
enum, also re-exports the inner variants.