Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Within Epsilon matcher #82

Merged
merged 1 commit into from
Oct 21, 2016
Merged

Within Epsilon matcher #82

merged 1 commit into from
Oct 21, 2016

Conversation

shterrett
Copy link
Contributor

For #75

I couldn't get the within_epsilon in the doctest; I think it's because I have it set to compile in test only.

@frewsxcv frewsxcv mentioned this pull request Oct 17, 2016
Closed
@TeXitoi
Copy link
Contributor

TeXitoi commented Oct 17, 2016

OK for me for the implementation. In practice, the choosen epsilon is quite small. But we can change that later if we have troubles.

@shterrett
Copy link
Contributor Author

I chose Float::epsilon for the tests that were "all but integer", partially because they all seemed to be working for everyone. The 1e-15 epsilon was chosen because the relative error between actual and expected in the failing test that I saw was 2e-16; I made it just a little bit larger.

@frewsxcv frewsxcv merged commit e7bbfac into georust:master Oct 21, 2016
@shterrett shterrett deleted the close-enough branch November 3, 2016 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shterrett @TeXitoi @frewsxcv