Use `Point::from(c)` instead of `Point(c)` #777

nyurik · 2022-03-17T14:53:13Z

Per discussion in #775, use the static from() instead of tuple ctor.

This will simplify migration to a different base type because type aliases do not support tuple instantiation.

Note that unlike the other similar PRs with ::new(v), this one uses the existing Point::from(v) fn because it directly assigns consumed values instead of converting them, and because it already has a Point::new(x, y)

I agree to follow the project's code of conduct.
~~[ ] I added an entry to CHANGES.md if knowledge of this change could be valuable to users.~~

779: Use `LineString::from()` instead of `LineString()` r=lnicola a=nyurik Make migration simpler by using static function that will still be available if `LineString` becomes a type alias. Similar to #777 - [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md). - ~[ ] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users.~ --- Co-authored-by: Yuri Astrakhan <YuriAstrakhan@gmail.com>

Make migration simpler by using static function that will still be available if `LineString` becomes a type alias. Similar to georust#777 - [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md). - ~[ ] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users.~ ---

Make migration simpler by using static function that will still be available if `MultiPolygon` becomes a type alias. Similar to georust#777

Make migration simpler by using static function that will still be available if `GeometryCollection` becomes a type alias. Note that `GeometryCollection::new()` already exists, and is the same as ::default(). I couldn't find any usages of it. I made `new()` deprecated, but the new method had to be something else - `new_from(val)`. Ideally, `new_from` should become `new(val)` Similar to georust#777

Make migration simpler by using static function that will still be available if `Triangle` becomes a type alias. Similar to georust#777

Make migration simpler by using static function that will still be available if `MultiLineString` becomes a type alias. Similar to georust#777

Make migration simpler by using static function that will still be available if `MultiPoint` becomes a type alias. Similar to georust#777

Make migration simpler by using static function that will still be available if `LineString` becomes a type alias. Similar to georust#777

… ctor. This will simplify migration to a different base type because type aliases do not support tuple instantiation. Note that unlike the other similar PRs with `::new(v)`, this one uses the existing `Point::from(v)` fn because it directly assigns consumed values instead of converting them, and because it already has a `Point::new(x, y)`

781: Use `LineString::new()` instead of `LineString()` r=frewsxcv a=nyurik Make migration simpler by using static function that will still be available if `LineString` becomes a type alias. Similar to #777 - [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md). - ~[ ] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users.~ --- Co-authored-by: Yuri Astrakhan <YuriAstrakhan@gmail.com>

Make migration simpler by using static function that will still be available if `MultiLineString` becomes a type alias. Similar to georust#777

Make migration simpler by using static function that will still be available if `MultiPolygon` becomes a type alias. Similar to georust#777

Make migration simpler by using static function that will still be available if `Triangle` becomes a type alias. Similar to georust#777

Make migration simpler by using static function that will still be available if `GeometryCollection` becomes a type alias. Note that `GeometryCollection::new()` already exists, and is the same as ::default(). I couldn't find any usages of it. I made `new()` deprecated, but the new method had to be something else - `new_from(val)`. Ideally, `new_from` should become `new(val)` Similar to georust#777

Make migration simpler by using static function that will still be available if `MultiLineString` becomes a type alias. Similar to georust#777

Make migration simpler by using static function that will still be available if `GeometryCollection` becomes a type alias. Note that `GeometryCollection::new()` already exists, and is the same as ::default(). I couldn't find any usages of it. I made `new()` deprecated, but the new method had to be something else - `new_from(val)`. Ideally, `new_from` should become `new(val)` Similar to georust#777

frewsxcv · 2022-03-19T02:54:18Z

bors r+

bors · 2022-03-19T02:59:35Z

Build succeeded:

ci result

786: Use `MultiPolygon::new()` instead of `MultiPolygon()` r=frewsxcv a=nyurik Make migration simpler by using static function that will still be available if `MultiPolygon` becomes a type alias. Similar to #777 - [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md). - [ ] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- Co-authored-by: Yuri Astrakhan <YuriAstrakhan@gmail.com>

783: Use `Triangle::new()` instead of `Triangle()` r=frewsxcv a=nyurik Make migration simpler by using static function that will still be available if `Triangle` becomes a type alias. Similar to #777 - [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md). - ~[ ] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users.~ --- Co-authored-by: Yuri Astrakhan <YuriAstrakhan@gmail.com>

778: Use `MultiPoint::new()` instead of `MultiPoint()` r=frewsxcv a=nyurik Make migration simpler by using static function that will still be available if `MultiPoint` becomes a type alias. Similar to #777 - [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md). - ~[ ] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users.~ --- Co-authored-by: Yuri Astrakhan <YuriAstrakhan@gmail.com>

Make migration simpler by using static function that will still be available if `GeometryCollection` becomes a type alias. Note that `GeometryCollection::new()` already exists, and is the same as ::default(). I couldn't find any usages of it. I made `new()` deprecated, but the new method had to be something else - `new_from(val)`. Ideally, `new_from` should become `new(val)` Similar to georust#777

Make migration simpler by using static function that will still be available if `MultiLineString` becomes a type alias. Similar to georust#777

784: Use `MultiLineString::new()` instead of `MultiLineString()` r=frewsxcv a=nyurik Make migration simpler by using static function that will still be available if `MultiLineString` becomes a type alias. Similar to #777 - [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md). - ~[ ] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users.~ --- Co-authored-by: Yuri Astrakhan <YuriAstrakhan@gmail.com>

782: Use `GeometryCollection::new_from()` instead of `GeometryCollection()` r=frewsxcv a=nyurik Make migration simpler by using static function that will still be available if `GeometryCollection` becomes a type alias. Note that `GeometryCollection::new()` already exists, and is the same as ::default(). I couldn't find any usages of it. I made `new()` deprecated, but the new method had to be something else - `new_from(val)`. Ideally, `new_from` should become `new(val)` Similar to #777 - [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md). - ~[ ] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users.~ --- Co-authored-by: Yuri Astrakhan <YuriAstrakhan@gmail.com>

This was referenced Mar 17, 2022

extend point! macro to support more ways to instantiate #775

Merged

Use MultiPoint::new() instead of MultiPoint() #778

Merged

lnicola approved these changes Mar 17, 2022

View reviewed changes

nyurik mentioned this pull request Mar 17, 2022

Use LineString::from() instead of LineString() #779

Merged

1 task

nyurik requested review from frewsxcv and rmanoka March 17, 2022 17:51

nyurik mentioned this pull request Mar 18, 2022

Use LineString::new() instead of LineString() #781

Merged

1 task

nyurik added a commit to nyurik/geo that referenced this pull request Mar 18, 2022

Use MultiPolygon::new() instead of MultiPolygon()

ae4a573

Make migration simpler by using static function that will still be available if `MultiPolygon` becomes a type alias. Similar to georust#777

nyurik mentioned this pull request Mar 18, 2022

Use GeometryCollection::new_from() instead of GeometryCollection() #782

Merged

1 task

nyurik added a commit to nyurik/geo that referenced this pull request Mar 18, 2022

Use Triangle::new() instead of Triangle()

ca021a4

Make migration simpler by using static function that will still be available if `Triangle` becomes a type alias. Similar to georust#777

nyurik mentioned this pull request Mar 18, 2022

Use Triangle::new() instead of Triangle() #783

Merged

1 task

nyurik added a commit to nyurik/geo that referenced this pull request Mar 18, 2022

Use MultiLineString::new() instead of MultiLineString()

e442361

Make migration simpler by using static function that will still be available if `MultiLineString` becomes a type alias. Similar to georust#777

nyurik mentioned this pull request Mar 18, 2022

Use MultiLineString::new() instead of MultiLineString() #784

Merged

1 task

nyurik added a commit to nyurik/geo that referenced this pull request Mar 18, 2022

Use MultiLineString::new() instead of MultiLineString()

393779a

Make migration simpler by using static function that will still be available if `MultiLineString` becomes a type alias. Similar to georust#777

nyurik added a commit to nyurik/geo that referenced this pull request Mar 18, 2022

Use MultiPoint::new() instead of MultiPoint()

1657dc0

Make migration simpler by using static function that will still be available if `MultiPoint` becomes a type alias. Similar to georust#777

nyurik added a commit to nyurik/geo that referenced this pull request Mar 18, 2022

Use LineString::new() instead of LineString()

1407258

Make migration simpler by using static function that will still be available if `LineString` becomes a type alias. Similar to georust#777

nyurik force-pushed the point-from branch from 3bf54da to c170b9a Compare March 18, 2022 21:58

nyurik added a commit to nyurik/geo that referenced this pull request Mar 19, 2022

Use MultiLineString::new() instead of MultiLineString()

6043f9b

Make migration simpler by using static function that will still be available if `MultiLineString` becomes a type alias. Similar to georust#777

nyurik added a commit to nyurik/geo that referenced this pull request Mar 19, 2022

Use MultiPolygon::new() instead of MultiPolygon()

cbb48cc

Make migration simpler by using static function that will still be available if `MultiPolygon` becomes a type alias. Similar to georust#777

nyurik added a commit to nyurik/geo that referenced this pull request Mar 19, 2022

Use Triangle::new() instead of Triangle()

a5cf700

Make migration simpler by using static function that will still be available if `Triangle` becomes a type alias. Similar to georust#777

nyurik added a commit to nyurik/geo that referenced this pull request Mar 19, 2022

Use MultiLineString::new() instead of MultiLineString()

e483c8e

Make migration simpler by using static function that will still be available if `MultiLineString` becomes a type alias. Similar to georust#777

nyurik mentioned this pull request Mar 19, 2022

Use MultiPolygon::new() instead of MultiPolygon() #786

Merged

2 tasks

frewsxcv approved these changes Mar 19, 2022

View reviewed changes

bors bot merged commit d040fe2 into georust:master Mar 19, 2022

nyurik added a commit to nyurik/geo that referenced this pull request Mar 28, 2022

Use MultiLineString::new() instead of MultiLineString()

60f5c52

Make migration simpler by using static function that will still be available if `MultiLineString` becomes a type alias. Similar to georust#777

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use `Point::from(c)` instead of `Point(c)` #777

Use `Point::from(c)` instead of `Point(c)` #777

nyurik commented Mar 17, 2022 •

edited

Loading

frewsxcv commented Mar 19, 2022

bors bot commented Mar 19, 2022

Use Point::from(c) instead of Point(c) #777

Use Point::from(c) instead of Point(c) #777

Conversation

nyurik commented Mar 17, 2022 • edited Loading

frewsxcv commented Mar 19, 2022

bors bot commented Mar 19, 2022

Use `Point::from(c)` instead of `Point(c)` #777

Use `Point::from(c)` instead of `Point(c)` #777

nyurik commented Mar 17, 2022 •

edited

Loading