-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Haversine distance #62
Conversation
Still learning! Anyone know whether there's a better way to avoid this longwinded series of T:from_i32 statements for an algorithm that works with both variables and constants? |
Something's going to have to be done about that. |
Please remove the warnings. |
Indeed, I'm very aware of the error, and will work on fixing it, nobody is expecting this PR to be merged with failing tests :) Anyone know the answer to the T::from_i32 question, though? |
I've had the same issue when using "actual numbers" within generic functions, and haven't been able to get around it, but I also haven't taken the time to ask anyone who works on/with |
OK, so the consensus seems to be something like:
I'd assumed it would be more complicated than that. |
6d390f7
to
b2239b7
Compare
@tmcw @frewsxcv this is most likely related to comparing floats using |
62: deserialize point r=frewsxcv a=michaelkirk - [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md). - [n/a] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. - > Add helper function for deserializing from WKT format into geo_types::Geometry I think the existing unreleased note pretty much covers it --- Addresses one little bit of georust/wkt#61, though leaves unanswered the bigger questions, around how to handle `GEOMETRYCOLLETION(POINT EMPTY)` etc. This might be controversial as it arguably muddies the water for addressing georust#61 more comprehensively. Please take a look at georust#61 for context. Co-authored-by: Michael Kirk <michael.code@endoftheworl.de>
No description provided.