Update Geometry enum and GeometryCollection #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urschrei
force-pushed
the
more_geometry_collection
branch
from
015b6b0 to
8144ae9
Compare
frewsxcv
approved these changes
Feb 29, 2020
urschrei
force-pushed
the
more_geometry_collection
branch
from
f91ab0c to
e8ce54c
Compare
This change deprecates the existing conversion functions.
urschrei
force-pushed
the
more_geometry_collection
branch
from
e8ce54c to
5c9c409
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 1, 2020
410: Update Geometry enum and GeometryCollection r=urschrei a=urschrei This PR: - Adds non-consuming iteration functionality (`iter()`, `iter_mut()`) and indexing to `GeometryCollection` - Adds `TryFrom` impls from `Geometry` enums to `Geo` primitives (deprecating but not removing the previous functions) - Doctest examples of working with `GeometryCollection` Co-authored-by: Stephan Hügel <urschrei@gmail.com> Co-authored-by: Stephan Hügel <shugel@tcd.ie>
Timed out |
|
bors retry |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
iter(),iter_mut()) and indexing toGeometryCollectionTryFromimpls fromGeometryenums toGeoprimitives (deprecating but not removing the previous functions)GeometryCollection