Add type Bbox and trait BoundingBox #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
July 14, 2016 07:34
| where T: Float | ||
| { | ||
| /// | ||
| /// Return the BoundingBox for a MultiLineString |
| /// let bbox = linestring.bbox().unwrap(); | ||
| /// | ||
| /// println!("Bbox top left coordinates: {}, {}", bbox.xmin, bbox.ymax); | ||
| /// println!("Bbox bottom right coordinates: {}, {}", bbox.xmax, bbox.ymin); |
There was a problem hiding this comment.
assert is generally used in docstring to reflect the expected behavior and because the code is tested by cargo test.
added 4 commits
July 19, 2016 07:02
…of a vector of Point<T>
|
OK for me. I'll merge it by squashing tomorrow if there is no objection. Great work! Thanks for your contribution! |
|
Oups, forgot to squash. Sorry. |
nyurik
pushed a commit
to nyurik/geo
that referenced
this pull request
Mar 19, 2022
41: update geo-types to 0.3 r=frewsxcv a=antoine-de Co-authored-by: antoine-de <antoine.desbordes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure that it is right to add the BoundingBox at the rust-geo project, since the boundingbox is not a geometry, but on the other hand it seems a sort of characteristic of the geometry.
What do you think?
Concerning the implementation I don't like too much how the trait BoundingBox is implemented (see: src/algorithm/boundingbox.rs) for MultiLineString and MultiPolygon, because the code is duplicated. I would like to move the code into a private function and call this function from the method, but I was not able to say at the function to take a parameter that can accept only MultiLineString or MultiPolygon. Any ideas on how I can implement this?
Do you see other improvements?