Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Euclidean Line-Line distance symmetrical #371

Merged
merged 3 commits into from
Jul 7, 2019
Merged

Make Euclidean Line-Line distance symmetrical #371

merged 3 commits into from
Jul 7, 2019

Conversation

Wassasin
Copy link
Contributor

@Wassasin Wassasin commented Jul 3, 2019

Fixes #370.

frewsxcv
frewsxcv approved these changes Jul 7, 2019
View reviewed changes
Copy link
Member

@frewsxcv frewsxcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After sketching this out, you're right. We need to check all vertices against the other lines. Good catch!

@frewsxcv
Copy link
Member

frewsxcv commented Jul 7, 2019

bors r+

bors bot added a commit that referenced this pull request Jul 7, 2019
@bors @Wassasin @frewsxcv
Merge #371
21dbed1 
371: Make Euclidean Line-Line distance symmetrical r=frewsxcv a=Wassasin

Fixes #370.

Co-authored-by: Wouter Geraedts <wouter@tweedegolf.com>
Co-authored-by: Corey Farwell <coreyf@rwell.org>
@bors
Copy link
Contributor

bors bot commented Jul 7, 2019

Build succeeded

@bors bors bot merged commit 03399a6 into georust:master Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frewsxcv frewsxcv frewsxcv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Euclidean Line-Line distance is not symmetrical
2 participants
@Wassasin @frewsxcv