Fix intersection for parallel lines #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audit. Also, x/y should be prefered to lng/lat as it's more general.
Using https://github.com/brandonxiang/geojson-python-utils/blob/33b4c00c6cf27921fb296052d0c0341bd6ca1af2/geojson_utils.py#L5 as a reference, there were several typos in our transcription of the algorithm. Fixing these typos fixes the parallel line test. WIP: Several polygon/linestring tests are now failing.
|
cc @azime |
| for (a1, a2) in vect0.iter().zip(vect0[1..].iter()) { | ||
| for (b1, b2) in vect1.iter().zip(vect1[1..].iter()) { | ||
| let u_b = (b2.y() - b1.y()) * (a2.x() - a1.x()) - | ||
| (b2.x() - b1.x()) * (a2.y() - a1.y()); | ||
| if u_b == 0. { | ||
| // The point is on boundary |
There was a problem hiding this comment.
Is this comment correct? TBH I don't really understand the code. @azime
There was a problem hiding this comment.
I didn't ignore miss this comment. I figure if either of you found out more about what this conditional is doing, one of you can address it in a follow-up PR; not reason to hold this one up.
There was a problem hiding this comment.
.@michaelkirk Unnecessary comment, I just delete it in PR : #36
.thank you for the correction
|
This is great, thank you so much for your contribution! ✨ |
nyurik
pushed a commit
to nyurik/geo
that referenced
this pull request
Mar 19, 2022
34: used last version of geo-types r=frewsxcv a=datanel Co-authored-by: David Quintanel <david.quintanel@canaltp.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was just backfilling a test for testing that parallel line strings don't intersect. This lead me to find a bug in the line segment intersection test.
Fixing that, uncovered another bug in the poly.intersect(line_string) implementation.
I renamed the variables in the line segment algorithm to correspond to the transcribed algorithm for easier auditing. You can see just the linestring intersection bug fix here:
093bb9a