Fix some edge case on centroid computation #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update the failure crate, else there is a conflict with the criterion's failure version
On some edge cases the centroid computation was returning (NaN, Nan) points. The edge cases were mainly when the area of a polygon was null.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 6, 2018
305: Fix some edge case on centroid computation r=frewsxcv a=antoine-de On some edge cases the centroid computation was returning (NaN, Nan) points. The edge cases were mainly when the area of a polygon was null (thus there was a division by 0). I studied what libgeos does for [this](https://github.com/libgeos/geos/blob/master/src/algorithm/Centroid.cpp#L45-L65), and I created a [jupyter notebook](https://gist.github.com/antoine-de/7f995a43a765a4b19720a09467ba8c51) (using shapely that uses libgeos) to show what libgeos was returning for the different edge cases. Note: as a side effect I had to update Failure version since criterion now use failure 0.1.2 Co-authored-by: Antoine D <antoine.desbordes@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some edge cases the centroid computation was returning (NaN, Nan) points.
The edge cases were mainly when the area of a polygon was null (thus there was a division by 0).
I studied what libgeos does for this, and I created a jupyter notebook (using shapely that uses libgeos) to show what libgeos was returning for the different edge cases.
Note: as a side effect I had to update Failure version since criterion now use failure 0.1.2