implement EuclideanDistance for MultiPolygon to Line and Line to MultiPolygon #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! |
|
@urschrei not surprisingly, our two commits went in conflict. Nothing serious though, it should be fixed by now. |
|
bors r=urschrei |
bors bot
added a commit
that referenced
this pull request
May 16, 2018
227: implement EuclideanDistance for MultiPolygon to Line and Line to MultiPolygon r=urschrei a=JivanRoquet
Implements the `EuclideanDistance` trait for the two following cases:
```rust
impl<T> EuclideanDistance<T, MultiPolygon<T>> for Line<T> { .. }
impl<T> EuclideanDistance<T, Line<T>> for MultiPolygon<T> { .. }
```
The test is not opinionated about the actual value being computed. It's only checking that the distance between the `Line` and the `MultiPolygon` is equal to the distance between the `Line` and the actual closest `Polygon` from this line.
More opinionated tests (aka, testing for real values) will be added once urschrei@90dee9d is merged, as this PR depends on this commit for its results.
Co-authored-by: Jivan Roquet <jivan.roquet@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
EuclideanDistancetrait for the two following cases:The test is not opinionated about the actual value being computed. It's only checking that the distance between the
Lineand theMultiPolygonis equal to the distance between theLineand the actual closestPolygonfrom this line.More opinionated tests (aka, testing for real values) will be added once urschrei@90dee9d is merged, as this PR depends on this commit for its results.