Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polygon-Line euclidean distance fix #226

Merged
merged 5 commits into from
May 16, 2018
Merged

Polygon-Line euclidean distance fix #226

merged 5 commits into from
May 16, 2018

Conversation

urschrei
Copy link
Member

@urschrei urschrei commented May 15, 2018 •
edited
Loading

See here: #219 (review)

WIP until I add tests for a Line contained in a Polygon interior ring and intersection

@urschrei
Copy link
Member Author

This implementation is incorrect for Lines contained by interior Polygon rings, because it does Point-Line distance for each Point in the containing interior Polygon ring. This is wrong, though – it should be doing Line-LineString distance (which is just the minimum of a series of Line-Line distances). Alas, this requires a Line-Line distance implementation, which I now have to write.

@urschrei urschrei mentioned this pull request May 16, 2018
Closed
@urschrei urschrei force-pushed the polygon_line_distance_fix branch from 66c599c to 8b71df6 Compare May 16, 2018 17:49
@urschrei
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request May 16, 2018
@bors @urschrei
Merge #226
af8c95b 
226: Polygon-Line euclidean distance fix r=urschrei a=urschrei

See here: #219 (review)

WIP until I add tests for a Line contained in a Polygon interior ring and intersection 

Co-authored-by: Stephan Hügel <stephan.hugel.12@ucl.ac.uk>
@bors
Copy link
Contributor

bors bot commented May 16, 2018

Build succeeded

@bors bors bot merged commit 8b71df6 into georust:master May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frewsxcv frewsxcv frewsxcv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@urschrei @frewsxcv