Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify wording for Contains algorithm. #220

Merged
merged 1 commit into from
May 15, 2018
Merged

Clarify wording for Contains algorithm. #220

merged 1 commit into from
May 15, 2018

Conversation

frewsxcv
Copy link
Member

No description provided.

Copy link
Contributor

@antoine-de antoine-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me.

maybe we can also detail a bit more the completely and add that sharing at least one point on the border means that neither geometry contains the other one (I think you can find a better way to explain this 😜 )

@frewsxcv
Copy link
Member Author

Agreed, I think we could have a couple edge-case examples for this. Going to do that in a follow-up PR at some point if that's cool, instead of blocking this one

bors r+

@frewsxcv
Copy link
Member Author

bors r=antoine-de

@bors
Copy link
Contributor

bors bot commented May 15, 2018

Not awaiting review

bors bot added a commit that referenced this pull request May 15, 2018
220: Clarify wording for Contains algorithm. r=frewsxcv a=frewsxcv



Co-authored-by: Corey Farwell <coreyf@rwell.org>
@bors
Copy link
Contributor

bors bot commented May 15, 2018

Build succeeded

@bors bors bot merged commit 0c9e1d9 into master May 15, 2018
@frewsxcv frewsxcv deleted the contains branch May 11, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants