Avoid Box in methods returning iterators #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! bors r+ |
bors bot
added a commit
that referenced
this pull request
May 12, 2018
218: Avoid Box in methods returning iterators r=frewsxcv a=lnicola Part of #198. This only uses `impl Iterator` for `lines`. The other methods can't use it because they're part of a trait. The code is a little ugly, and replacing `Points` with `impl Trait` in the future will be a breaking change. Feel free to close if you think it's not worth it. For what it's worth, if we do switch to `impl Iterator` in the future, writing down the ugly `EitherIter<&'a Point<T>, Iter<'a, Point<T>>, Rev<Iter<'a, Point<T>>>>` type will no longer be needed. Co-authored-by: Laurentiu Nicola <lnicola@dend.ro>
|
Maybe it would be worth noting the minimum compiler version in the release notes? |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #198.
This only uses
impl Iteratorforlines. The other methods can't use it because they're part of a trait.The code is a little ugly, and replacing
Pointswithimpl Traitin the future will be a breaking change. Feel free to close if you think it's not worth it.For what it's worth, if we do switch to
impl Iteratorin the future, writing down the uglyEitherIter<&'a Point<T>, Iter<'a, Point<T>>, Rev<Iter<'a, Point<T>>>>type will no longer be needed.