Implement VincentyDistance and VincentyLength #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frewsxcv
force-pushed
the
vincenty
branch
2 times, most recently
from
98cf7d7 to
8cd4be4
Compare
|
@urschrei Do you feel comfortable reviewing this? |
|
Vincenty can fail to converge for certain antipodal points (see here: geopy/geopy#30), and Charles Karney has actually provided a method that's guaranteed to converge in Geopy. I think we should return a |
|
lgtm! |
|
bors r=urschrei |
bors bot
added a commit
that referenced
this pull request
May 19, 2018
213: Implement VincentyDistance and VincentyLength r=urschrei a=frewsxcv Fixes #205 Based off this implementation: https://github.com/janantala/GPS-distance/blob/master/java/Distance.java Co-authored-by: Corey Farwell <coreyf@rwell.org>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #205
Based off this implementation: https://github.com/janantala/GPS-distance/blob/master/java/Distance.java