Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix Euclidean distance/length traits with 'Euclidean'. #200

Merged
merged 1 commit into from
Apr 11, 2018

Conversation

frewsxcv
Copy link
Member

I think we should make it explicit what algorithm the Distance/Length traits use. The Distance/Length naming suggests they should be used for most scenarios, even though the user probably wants Haversine, right?

@frewsxcv frewsxcv requested a review from urschrei April 11, 2018 02:01
@frewsxcv frewsxcv force-pushed the frewsxcv-euclidean branch from 7ec1702 to f249f1b Compare April 11, 2018 02:32
@urschrei
Copy link
Member

I would have thought most people wanted Euclidean, but this removes any ambiguity, so 👍.

@frewsxcv
Copy link
Member Author

bors r=urschrei

bors bot added a commit that referenced this pull request Apr 11, 2018
200: Prefix Euclidean distance/length traits with 'Euclidean'. r=urschrei a=frewsxcv

I think we should make it explicit what algorithm the `Distance`/`Length` traits use. The `Distance`/`Length` naming suggests they should be used for most scenarios, even though the user probably wants Haversine, right?

Co-authored-by: Corey Farwell <coreyf@rwell.org>
@bors
Copy link
Contributor

bors bot commented Apr 11, 2018

Build succeeded

@bors bors bot merged commit f249f1b into master Apr 11, 2018
@frewsxcv frewsxcv deleted the frewsxcv-euclidean branch April 13, 2018 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants