Impl Polygon convexity function on the type #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The convexity function was previously only available within the Extremes module, but it's generally useful and will be required by other algorithms. This moves the function and implements it directly on the type.
frewsxcv
reviewed
Mar 29, 2018
src/types.rs
Outdated
| false | ||
| } else { | ||
| true | ||
| } |
There was a problem hiding this comment.
these last five lines can just be convex != ListSign::Mixed
src/types.rs
Outdated
| // The polygon is convex if the z-components of the cross products are either | ||
| // all positive or all negative. Otherwise, the polygon is non-convex. | ||
| // see: http://stackoverflow.com/a/1881201/416626 | ||
| pub fn convex(&self) -> bool { |
There was a problem hiding this comment.
most things that return bool usually start with is_ or has_. what do you think about calling this is_convex?
|
Addressed! |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 29, 2018
195: Impl Polygon convexity function on the type r=frewsxcv a=urschrei The convexity function was previously only available within the Extremes module, but it's generally useful and will be required by other algorithms. This moves the function and implements it directly on the type.
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The convexity function was previously only available within the
Extremes module, but it's generally useful and will be required by
other algorithms. This moves the function and implements it directly
on the type.