Allow coordinates to be more types #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 11, 2018 14:23
frewsxcv
approved these changes
Mar 11, 2018
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 11, 2018
187: Allow coordinates to be more types r=frewsxcv a=rory This PR allows the coordinates to be a larger range of types, not just `Float`. Specially it allows for integer coordinates. Some algorithms have been 'expanded' to support this new `CoordinateType`, but most only make sense for `Float`s and have been left. I've only changed what I've used myself, perhaps more algorithms could be expanded. I think this should be a backwards compatible change. This fixes #137
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the coordinates to be a larger range of types, not just
Float. Specially it allows for integer coordinates. Some algorithms have been 'expanded' to support this newCoordinateType, but most only make sense forFloats and have been left. I've only changed what I've used myself, perhaps more algorithms could be expanded. I think this should be a backwards compatible change.This fixes #137