You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not exactly question about this PR, but generally – is implementing SpatialObject for other types (like Polygon) is planned (or how do I implement them in my code)?
@floatdrop I haven't really thought about implementing it for any other types, because we haven't yet had to use RTree to store them. It should be easy to do for LineString, but I'm less sure whether it would be useful for Polygon. In terms of implementing it for your own types, you first need to Implement PointN and TwoDimensional for your point type (see here for ours), and then implement SpatialObject as in this PR.
@urschrei thanks for quick response! My question was more about – how do I implement SpatialObject for Polygon? Because these traits are not in scope of my library – rust refuses to accept implementation (or I just do it wrong).
@floatdrop As you say, you won't be able to do it yourself, because Polygon is a foreign type. So you have two options: use a wrapper type, or store the Polygon's exterior asLines (when this PR lands), and then use that for querying.
181: Implement SpatialObject for Line type r=frewsxcv a=urschrei
This doesn't get us any speedup, but it _does_ let us use the `Line` type directly in an `RTree`, which reduces complexity quite a bit.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
urschrei
force-pushed
the
impl_line_spatialobject
branch
from
This doesn't get us any speedup, but it does let us use the
Linetype directly in anRTree, which reduces complexity quite a bit.