Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clippy pass, rustfmt pass, typo fixes, enum addition #179

Merged
merged 5 commits into from
Jan 14, 2018
Merged

Clippy pass, rustfmt pass, typo fixes, enum addition #179

merged 5 commits into from
Jan 14, 2018

Conversation

urschrei
Copy link
Member

99% of these changes are from rustfmt – the rest are changes suggested by Clippy, which now only finds a single issue.
I've also tidied up some doc typos, and added Line to the Geometry enum.

@urschrei urschrei requested a review from frewsxcv January 10, 2018 23:34
@frewsxcv
Copy link
Member

everything looks good here, nice work! the only thing to note here is that 816e2e8 should be considered a breaking change (which is fine!) since someone could have been matching on the Geometry enum prior to that commit and now it will error since they're missing a Geometry::Line branch. if that's cool, r=me

@urschrei
Copy link
Member Author

Ah, good catch. I think it'll have to be OK, since we're pre-1.0, and it was going have to go in at some point. We should probably cut a release in any case - lmk if you want me to write up the notes etc.

@urschrei
Copy link
Member Author

urschrei commented Jan 14, 2018 •
edited
Loading

bors r=frewsxcv

@frewsxcv
Copy link
Member

bors r+

i don't think you can edit a comment and have bors pick it up

bors bot added a commit that referenced this pull request Jan 14, 2018
@bors
Merge #179
523ac03 
179: Clippy pass, rustfmt pass, typo fixes, enum addition r=frewsxcv a=urschrei

99% of these changes are from `rustfmt` – the rest are changes suggested by Clippy, which now only finds a single issue.
I've also tidied up some doc typos, and added `Line` to the `Geometry` enum.
@bors
Copy link
Contributor

bors bot commented Jan 14, 2018

Build succeeded

@bors bors bot merged commit 9d360e9 into georust:master Jan 14, 2018
@urschrei urschrei deleted the rustfmt_clippy branch January 14, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frewsxcv frewsxcv Awaiting requested review from frewsxcv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@urschrei @frewsxcv