Add Polygon-Polygon containment predicate and tests #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frewsxcv
reviewed
Sep 10, 2017
src/algorithm/contains.rs
Outdated
| { | ||
| fn contains(&self, poly: &Polygon<T>) -> bool { | ||
| // decompose poly's exterior ring into Lines, and check each for containment | ||
| poly.exterior.0.windows(2).all(|line| { |
There was a problem hiding this comment.
We should maybe add a lines_iter on LineString that returns a Box<Iterator<Item=Line>> or something of the like
Nevermind, I already wrote it :D #160
urschrei
force-pushed
the
polygon_containment
branch
from
d719965 to
cb0e192
Compare
|
🎊 🎊 🎊 🎊 🎊 bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.