Correctly check for LineString containment in Polygon #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Sep 6, 2017
We're sticking to polygons which have convex hulls for now, and are checking for that. The two failing tests are dependent upon georust#157 closing when georust#158 merges.
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Sep 10, 2017
We're sticking to polygons which have convex hulls for now, and are checking for that. The two failing tests are dependent upon georust#157 closing when georust#158 merges.
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Sep 10, 2017
We're sticking to polygons which have convex hulls for now, and are checking for that. The two failing tests are dependent upon georust#157 closing when georust#158 merges.
|
lgtm! r=me once the merge conflict is addressed |
The [DE-9IM specification for [`containment`] (http://docs.safe.com/fme/html/FME_Desktop_Documentation/FME_Transformers/Transformers/spatialrelations.htm#DE9IM_Matrix) states: > The **interiors intersect** and no part of the candidate's interior or boundary intersects the base's exterior. It is possible for the boundaries to intersect. For `intersection`: > The two features are not disjoint For `disjoint` > The boundaries and interiors do not intersect. The current containment check deviates from this, in that it forbids intersection (`!self.intersects(linestring)`), when in fact it should be forbidding intersection with any _interior rings_. This PR fixes that, and adds a test. closes georust#157
urschrei
force-pushed
the
containment_check_fix
branch
from
d1ba7f4 to
0c9904a
Compare
|
r=frewsxcv |
|
bors r=frewsxcv |
bors bot
added a commit
that referenced
this pull request
Sep 10, 2017
158: Correctly check for LineString containment in Polygon r=frewsxcv a=urschrei The DE-9IM specification for [`containment`](http://docs.safe.com/fme/html/FME_Desktop_Documentation/FME_Transformers/Transformers/spatialrelations.htm#DE9IM_Matrix) states: > The **interiors intersect** and no part of the candidate's interior or boundary intersects the base's exterior. It is possible for the boundaries to intersect. For `intersection` > The two features are not disjoint For `disjoint` > The boundaries and interiors do not intersect. The current containment check deviates from this, in that it forbids intersection (`!self.intersects(linestring)`), when in fact it should be forbidding intersection with any _interior rings_. This PR fixes that, and adds a test. closes #157
Build succeeded |
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Sep 10, 2017
We're sticking to polygons which have convex hulls for now, and are checking for that. The two failing tests are dependent upon georust#157 closing when georust#158 merges.
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Sep 11, 2017
We're sticking to polygons which have convex hulls for now, and are checking for that. The two failing tests are dependent upon georust#157 closing when georust#158 merges.
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Sep 19, 2017
We're sticking to polygons which have convex hulls for now, and are checking for that. The two failing tests are dependent upon georust#157 closing when georust#158 merges.
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Sep 26, 2017
We're sticking to polygons which have convex hulls for now, and are checking for that. The two failing tests are dependent upon georust#157 closing when georust#158 merges.
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Oct 11, 2017
We're sticking to polygons which have convex hulls for now, and are checking for that. The two failing tests are dependent upon georust#157 closing when georust#158 merges.
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Oct 16, 2017
We're sticking to polygons which have convex hulls for now, and are checking for that. The two failing tests are dependent upon georust#157 closing when georust#158 merges.
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Nov 6, 2017
We're sticking to polygons which have convex hulls for now, and are checking for that. The two failing tests are dependent upon georust#157 closing when georust#158 merges.
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Jan 7, 2018
We're sticking to polygons which have convex hulls for now, and are checking for that. The two failing tests are dependent upon georust#157 closing when georust#158 merges.
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Jan 12, 2018
We're sticking to polygons which have convex hulls for now, and are checking for that. The two failing tests are dependent upon georust#157 closing when georust#158 merges.
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Jan 14, 2018
We're sticking to polygons which have convex hulls for now, and are checking for that. The two failing tests are dependent upon georust#157 closing when georust#158 merges.
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Jan 25, 2018
We're sticking to polygons which have convex hulls for now, and are checking for that. The two failing tests are dependent upon georust#157 closing when georust#158 merges.
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Jan 28, 2018
We're sticking to polygons which have convex hulls for now, and are checking for that. The two failing tests are dependent upon georust#157 closing when georust#158 merges.
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Feb 4, 2018
We're sticking to polygons which have convex hulls for now, and are checking for that. The two failing tests are dependent upon georust#157 closing when georust#158 merges.
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Mar 1, 2018
We're sticking to polygons which have convex hulls for now, and are checking for that. The two failing tests are dependent upon georust#157 closing when georust#158 merges.
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Mar 2, 2018
We're sticking to polygons which have convex hulls for now, and are checking for that. The two failing tests are dependent upon georust#157 closing when georust#158 merges.
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Mar 4, 2018
We're sticking to polygons which have convex hulls for now, and are checking for that. The two failing tests are dependent upon georust#157 closing when georust#158 merges.
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Mar 11, 2018
We're sticking to polygons which have convex hulls for now, and are checking for that. The two failing tests are dependent upon georust#157 closing when georust#158 merges.
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Mar 12, 2018
We're sticking to polygons which have convex hulls for now, and are checking for that. The two failing tests are dependent upon georust#157 closing when georust#158 merges.
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Mar 15, 2018
We're sticking to polygons which have convex hulls for now, and are checking for that. The two failing tests are dependent upon georust#157 closing when georust#158 merges.
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Mar 15, 2018
We're sticking to polygons which have convex hulls for now, and are checking for that. The two failing tests are dependent upon georust#157 closing when georust#158 merges.
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Mar 20, 2018
We're sticking to polygons which have convex hulls for now, and are checking for that. The two failing tests are dependent upon georust#157 closing when georust#158 merges.
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Mar 29, 2018
We're sticking to polygons which have convex hulls for now, and are checking for that. The two failing tests are dependent upon georust#157 closing when georust#158 merges.
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Apr 9, 2018
We're sticking to polygons which have convex hulls for now, and are checking for that. The two failing tests are dependent upon georust#157 closing when georust#158 merges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DE-9IM specification for
containmentstates:For
intersectionFor
disjointThe current containment check deviates from this, in that it forbids
intersection (
!self.intersects(linestring)), when in fact it shouldbe forbidding intersection with any interior rings. This PR fixes
that, and adds a test.
closes #157