add .map_coords() function to convert all coordinates in a shape #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the future, it might be nice if these methods returned structures that implement bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 13, 2017
136: add .map_coords() function to convert all coordinates in a shape r=frewsxcv I added the ability to apply a function to all coordinates. This is a general function which will change all the coordinates in a geometry. You can even change the type of the coordinates, e.g. if you want to change from `f32` to `f64`. This gives ultimate flexibility. Some of the other traits (e.g. Translation) could probably be rewritten to take advantage of this change, but my first simple attempt failed. I'm not 100% happy with the syntax, `p.map_coords(&|&(x, y)| ...` has too many `&` and stuff, so I'm open to suggestions on if this can be improved.
Build succeeded |
|
Will cut a new release later when I'm back at my computer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the ability to apply a function to all coordinates. This is a general function which will change all the coordinates in a geometry. You can even change the type of the coordinates, e.g. if you want to change from
f32tof64. This gives ultimate flexibility.Some of the other traits (e.g. Translation) could probably be rewritten to take advantage of this change, but my first simple attempt failed.
I'm not 100% happy with the syntax,
p.map_coords(&|&(x, y)| ...has too many&and stuff, so I'm open to suggestions on if this can be improved.