Implement distance traits for more geometries #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are just the inverse of existing impls, provided for convenience
frewsxcv
reviewed
Apr 2, 2017
| @@ -10,10 +10,10 @@ use num_traits::pow::pow; | |||
| pub trait Distance<T, Rhs = Self> { | |||
| /// Returns the distance between two geometries | |||
| /// | |||
| /// If a `Point` is contained by a `Polygon`, the distance is `0.0` | |||
There was a problem hiding this comment.
I think these spaces might have been intentional because markdown treats them as newlines:
http://spec.commonmark.org/0.26/#hard-line-breaks
I think with your changes, these sentences get put on the same line
|
Thanks for this! It's unfortunate that we can't do something like #73 bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 2, 2017
113: Implement distance traits for more geometries r=frewsxcv This PR adds distance traits for all geometries for which the trait was already implemented in one direction. E.g. if `Point`-to-`Polygon` distance existed, `Polygon`-to-`Point` distance now also exists. This adds a few boilerplate functions, but I can't think of a more ergonomic solution. Still missing: - `LineString`-to-`LineString` minimum distance (is there a good algorithm for this?) - `Polygon`-to-`Polygon` minimum distance (I'm (slowly) working on a [rotating calipers](http://web.archive.org/web/20150407022621/http://cgm.cs.mcgill.ca/~orm/mind2p.html) implementation)
Build succeeded |
|
That would be great, and I did wonder whether something like that would be possible given the symmetry of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds distance traits for all geometries for which the trait was already implemented in one direction. E.g. if
Point-to-Polygondistance existed,Polygon-to-Pointdistance now also exists. This adds a few boilerplate functions, but I can't think of a more ergonomic solution.Still missing:
LineString-to-LineStringminimum distance (is there a good algorithm for this?)Polygon-to-Polygonminimum distance (I'm (slowly) working on a rotating calipers implementation)