Correctly calculate centroids for complex polygons. #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
complex polygons (i.e. with interior holes)
TeXitoi
approved these changes
Mar 30, 2017
Showing a numerical result is preferable to (NaN, NaN)
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Mar 31, 2017
This test will fail until georust#112 is merged
Merged
|
Is this ready to go? Looks good to me if so! |
|
Yep! |
|
bors=frewsxcv,texitoi |
|
bors r=frewsxcv,texitoi |
bors bot
added a commit
that referenced
this pull request
Apr 2, 2017
112: Correctly calculate centroids for complex polygons. r=frewsxcv,texitoi This PR closes #111. I've added helper functions for calculation of a simple polygon centroid, and for simple polygon area. The latter is functionally identical to `get_linestring_area()`, but we can't use that since it's a private function in a public module.
Build succeeded |
urschrei
added a commit
to urschrei/geo
that referenced
this pull request
Apr 10, 2017
This test will fail until georust#112 is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #111. I've added helper functions for calculation of a simple polygon centroid, and for simple polygon area. The latter is functionally identical to
get_linestring_area(), but we can't use that since it's a private function in a public module.