-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hausdorff Distance trait #1041
Conversation
@frewsxcv thanks! I've added a note in the documentation that it uses euclidean distance. Is this explicit enough? I've also added a handful of tests as well. Please let me know if this is sufficient or if there ought to be exhaustive tests (every combo of geometry types). |
I've pushed a commit that addresses formatting using |
I've added a note to the changelog. Please let me know what else is needed to close this PR. Thanks! :) |
bors r+ |
1041: Add Hausdorff Distance trait r=michaelkirk a=JosiahParry - [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/main/CODE_OF_CONDUCT.md). - [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- This PR adds a new trait `HausdorffDistance` which is implemented for all geometries. This is my first Rust library PR so I'll need some guidance getting this through the finish line! ### Outstanding questions for maintainers: - This PR is lacking tests. Should there be a test for each combo of geometry? - `CHANGES.md` does not have a development version listed, how should it be modified? - what amount of documentation is needed / suggested? Co-authored-by: Josiah Parry <josiah.parry@gmail.com>
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: Response status code: 422
{"message":"Changes must be made through the merge queue","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
bors retry Whoops. My bad I think. Let's try again now that I have (for real this time) disabled the merge queue. |
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Thanks! |
Thank you! |
CHANGES.md
if knowledge of this change could be valuable to users.This PR adds a new trait
HausdorffDistance
which is implemented for all geometries.This is my first Rust library PR so I'll need some guidance getting this through the finish line!
Outstanding questions for maintainers:
CHANGES.md
does not have a development version listed, how should it be modified?