Skip to content

serde is not supported for Geometry and GeometryCollection #702

Closed
@msalib

Description

Serializing one of those doesn't work because there is no #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] for either of those types.

Activity

martinfrances107

martinfrances107 commented on Dec 27, 2021

@martinfrances107
Contributor

+1 I think this needs to be made complete.

When I first saw it, a month ago I was in a rush and did not have time to fix it upstream ...here

The ugly workaround I used was to loop over geometry colections inner elements and serialize/deserialise each element individually ...

I would be happy to help out here...

added a commit that references this issue on Dec 27, 2021

georust#702 Geometry Collection now suports serde.

martinfrances107

martinfrances107 commented on Dec 27, 2021

@martinfrances107
Contributor

So I have created an initial patch ... testing is on my mind. Geometry primitives like point do not have explicit testing for serde. So I am not sure how to fit in testing?

added a commit that references this issue on Dec 28, 2021
3a9303d
frewsxcv

frewsxcv commented on Dec 30, 2021

@frewsxcv
Member

Done in #704

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      serde is not supported for `Geometry` and `GeometryCollection` · Issue #702 · georust/geo