Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract cross product operation #133

Closed
mbattifarano opened this issue Aug 5, 2017 · 3 comments
Closed

Extract cross product operation #133

mbattifarano opened this issue Aug 5, 2017 · 3 comments
Labels
good first issue

Comments

@mbattifarano
Copy link
Member

The cross product of two points is implemented inline in several places. We should implement a cross product method directly on Point.

See also: #132 (comment)
@mbattifarano mbattifarano mentioned this issue Aug 5, 2017
Closed
@frewsxcv
Copy link
Member

here are the two implementations which could be put on Point:

@Jay9596
Copy link
Contributor

Jay9596 commented Mar 11, 2018

I would like to work on this issue.
Should I change the occurrences or leave them be and change them after submitting the PR with the cross fn as part of Point.

@frewsxcv
Copy link
Member

@Jay9596 thanks for taking this on! you can go ahead and change the existing occurrences to use the new method

@Jay9596 Jay9596 mentioned this issue Mar 11, 2018
Merged
bors bot added a commit that referenced this issue Mar 12, 2018
@bors
Merge #189
fb7bb7c 
189: cross_prod method added to Point r=frewsxcv a=Jay9596

Solves #133 

`Point` struct  now implements a cross product fuction `cross_prod` that use previously used inline in 2 different parts of the codebase.
- algorithm/extremes.rs
- algorithm/convexhull.rs

It uses the same implementation the other inline function were using.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@frewsxcv @mbattifarano @Jay9596