Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: fix imports tests with latest pytest-cov #3455

Merged

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Nov 5, 2024

Based on the explanation in https://pytest-cov.readthedocs.io/en/latest/subprocess-support.html#subprocess-support, this might prevent pytest-cov getting imported in the subprocess (and importing that might trigger import pytest)

@jorisvandenbossche
Copy link
Member Author

This seems to work!

@jorisvandenbossche jorisvandenbossche marked this pull request as ready for review November 5, 2024 17:00
@jorisvandenbossche
Copy link
Member Author

Some failures in the dev build because of a recent pandas PR: pandas-dev/pandas#60046 (comment)

Copy link
Member

@m-richards m-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bottoming this out!

@m-richards m-richards merged commit c681820 into geopandas:main Nov 5, 2024
17 of 18 checks passed
@jorisvandenbossche jorisvandenbossche deleted the fix-pytest-cov-failure branch November 5, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants