Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add 3.13 to test matrix #3427

Merged
merged 8 commits into from
Oct 29, 2024
Merged

CI: add 3.13 to test matrix #3427

merged 8 commits into from
Oct 29, 2024

Conversation

m-richards
Copy link
Member

No description provided.

@m-richards m-richards marked this pull request as draft September 24, 2024 22:09
@martinfleis
Copy link
Member

Do you think it is worth it? If I remember correctly we always tested new versions only once the migration of conda-forge was sufficiently far.

@m-richards
Copy link
Member Author

Do you think it is worth it? If I remember correctly we always tested new versions only once the migration of conda-forge was sufficiently far.

I'm inclined to just wait now - I thought I'd see if it was easy to do- and by the looks it's not super simple. We don't have any compiled code so at worst I think some deprecation warnings would surface, which we can fix after 3.13 is out.

@m-richards
Copy link
Member Author

looks like we're waiting on pyarrow 18 to come out (we could temporarily drop pyarrow stuff from the build, but it's probably easier to just wait)

@m-richards m-richards marked this pull request as ready for review October 23, 2024 12:04
@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Oct 23, 2024

PyArrow 18 is in the RC phase, so hopefully available something like next week. But temporarily commenting it out from the env file or installing from nightly sounds fine as well.

@martinfleis
Copy link
Member

I would prefer not to use nightly wheels here. It may stuck there for a while. But I am fine testing without pyarrow.

@m-richards
Copy link
Member Author

I think I'll just leave this until pyarrow is out then - the main thing is that 3.13 is not breaking and we can see that from the last commit

@m-richards
Copy link
Member Author

pyarrow 18 came out yesterday, and this is now installing it and passing.

@m-richards m-richards merged commit 553fabe into geopandas:main Oct 29, 2024
18 checks passed
@m-richards m-richards deleted the 3.13 branch October 29, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants