Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexing / Add field if a keyword is not found in thesaurus. #5684

Merged
merged 3 commits into from
May 20, 2021

Conversation

fxprunayre
Copy link
Member

@fxprunayre fxprunayre commented May 12, 2021

  • Indexing / Add field if a keyword is not found in thesaurus to easily track keywords which may have been removed from a thesaurus

image

  • Editor / Add warning and options to only remove those keywords not found in a thesaurus (so that user can remove those and update others)

image

@fxprunayre fxprunayre added this to the 4.0.5 milestone May 12, 2021
@josegar74
Copy link
Member

It doesn't work for me. I select the keywords and looks fine, but saving the metadata, the keyword picker is empty. in this code, after saving the editor scope.keywords is empty:

Test done:

  • Load GEMET thesaurus.
  • Create an iso19139 metadata with the default template.
  • Add some GEMET keywords --> The widget displays the selected keywords.
  • Save the metadata --> The widget content is empty. No errors in the log.
  • Tried the same with the Regions thesaurus, with same results.

@josegar74 josegar74 self-requested a review May 18, 2021 09:56
@fxprunayre
Copy link
Member Author

It doesn't work for me.

I can't reproduce your case. Can you check that the list of keywords is set in the directive attribute?
image

@josegar74
Copy link
Member

Repeated the steps described previously with a clean checkout, I get the same issue. This is the html snippet I have after saving the metadata:

<div data-gn-keyword-selector="tagsinput" data-metadata-id="110" data-element-ref="_X120_replace" data-thesaurus-title="GEMET - INSPIRE themes, version 1.0" 
data-thesaurus-key="external.theme.httpinspireeceuropaeutheme-theme" 
data-keywords="" 
data-transformations="to-iso19139-keyword,to-iso19139-keyword-with-anchor,to-iso19139-keyword-as-xlink" 
data-current-transformation="to-iso19139-keyword" data-max-tags="" data-order-by-id="false" data-lang="{&quot;eng&quot;:&quot;#&quot;}" 
data-textgroup-only="false" class="ng-isolate-scope">

We can't have xpath mode (used in DCAT) and snippet replace at the same time.
Copy link
Member

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine with the latest changes.

@fxprunayre fxprunayre merged commit b715117 into main May 20, 2021
@fxprunayre fxprunayre deleted the 405-indexing-keyword branch May 24, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants