Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tests to stop using NYU fixture #1526

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Change tests to stop using NYU fixture #1526

merged 1 commit into from
Aug 15, 2024

Conversation

thatbudakguy
Copy link
Member

This fixes an HTTP timeout error that could arise when an NYU
fixture was queried over WMS and didn't respond in time, causing
tests to fail.

This commit switches the two tests that used the fixture to use
other, equivalent fixtures to avoid the timeouts.

See also #1492.

This fixes an HTTP timeout error that could arise when an NYU
fixture was queried over WMS and didn't respond in time, causing
tests to fail.

This commit switches the two tests that used the fixture to use
other, equivalent fixtures to avoid the timeouts.

See also #1492.
Copy link

Demo app download link: https://github.com/geoblacklight/geoblacklight/actions/runs/10409932215/artifacts/1817384724

  1. Download demo app and unzip file
  2. Change into app directory
    • run docker compose pull
    • run docker compose up
  3. Open in browser

@thatbudakguy thatbudakguy marked this pull request as ready for review August 15, 2024 20:24
Copy link
Member

@ewlarson ewlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ewlarson ewlarson merged commit f9c00c0 into main Aug 15, 2024
11 checks passed
@ewlarson ewlarson deleted the change-fixture branch August 15, 2024 20:27
@karenmajewicz karenmajewicz mentioned this pull request Aug 15, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants