Update testing configuration #1426
Merged
+10
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The long timeouts and other options we were manually specifying no longer seem necessary.
We can just use transactional fixtures.
thatbudakguy
force-pushed
the
test-config
branch
from
129208b to
96460c9
Compare
thatbudakguy
force-pushed
the
test-config
branch
from
63d8fea to
9f83451
Compare
jmartin-sul
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the custom Selenium configuration, since it didn't seem to affect the vast majority of the tests and included some complex options (huge window size, long timeouts, etc.) that made local testing harder.
It also stops using database cleaner, since transactional fixtures work just as well.