Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for static sidebar maps like the BTAA Geoportal. #1295

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

ewlarson
Copy link
Member

This PR adds a new feature configured via the settings.yml Settings.SIDEBAR_STATIC_MAP list of viewer protocols. When a document's viewer protocol match is found, we'll render a static map and geom bbox for the :iiif or :iiif_manifest in the catalog#show sidebar.

Fixes #726

Screenshots from spec/fixtures:

http://localhost:3000/catalog/princeton-02870w62c

Screenshot 2023-06-11 at 3 32 45 PM

http://localhost:3000/catalog/princeton-1r66j405w

Screenshot 2023-06-11 at 3 32 40 PM

@ewlarson ewlarson self-assigned this Jun 11, 2023
@ewlarson ewlarson added this to the v4.1.0 milestone Jun 11, 2023
@ewlarson ewlarson changed the title 726 iiif static inset map Add support for static sidebar maps like the BTAA Geoportal. Jun 11, 2023
@ewlarson
Copy link
Member Author

ewlarson commented Jun 11, 2023

Todos:

  • Add some kind of testing
  • Add v4.1 settings.yml changes to an initializer (to follow in another PR)

@ewlarson ewlarson marked this pull request as ready for review June 12, 2023 15:57
ewlarson added 3 commits June 13, 2023 08:10
Configured via settings.yml's Settings.SIDEBAR_STATIC_MAP list of viewer protocols. When a match is found, we'll render a static map and geom bbox for the iiif or iiif_manifest in the catalog#show sidebar.

Fixes #726
@ewlarson ewlarson force-pushed the 726-iiif-static-inset-map branch from a2da26c to 9f85539 Compare June 13, 2023 13:11
@ewlarson ewlarson requested a review from dl-maura June 13, 2023 13:33
Copy link
Contributor

@dl-maura dl-maura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works locally

@dl-maura dl-maura merged commit 286308b into main Jun 13, 2023
@dl-maura dl-maura deleted the 726-iiif-static-inset-map branch June 13, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding a map inset widget for IIIF images to show bounding box
2 participants