cloudap support for versions > 1909 #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works great on my test hosts, thanks for this fix! |
|
If @dirkjanm validate the result, who am I to refuse the merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows builds > 1909 use a slightly different memory structure for
KIWI_CLOUDAP_LOGON_LIST_ENTRY.Updated header file to include this new structure.
Wrapped the sekurlsa cloudap logic around an if statement that uses the new structure if the reported build is > 1909. I'm not sure if this is the logic you prefer or if there is a more elegant way to toggle which struct to use based on build number, my C is rusty :) . I've also not tested on 32-bit OSes.