Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read (and use) node position annotations from stored in the Minerva models #113

Closed
kltm opened this issue Apr 29, 2015 · 6 comments
Closed

Comments

@kltm
Copy link
Member

kltm commented Apr 29, 2015

@hdietze has recently exposed "layout-hint-x" and "layout-hint-y" as per-node annotations that can be round-tripped for experimentation.

We'll play with these and see how they work.

In the end, I suspect that we'll have "hint-layout-x", etc., as per-model meta.

@kltm
Copy link
Member Author

kltm commented Apr 29, 2015

My initial guess is to have the clients read these directly and only update Barista's during movement (which should be the default anyways).

@kltm
Copy link
Member Author

kltm commented May 7, 2015

The three parts of correct handling.

Reading

  • when opening a model, if "current" information information is not available from barista, use the information in the hint-layout-x, etc.

Use

  • moment-to-moment information comes from barista
  • during a complete redraw, may fall back on Reading

Writing

  • as part of the "save" batch, the manager should
    • add all currently held node location information as annotations
    • tag that on first before adding "save" to batch

@kltm kltm modified the milestones: 2015-05-push, 2015-06-push Jun 1, 2015
@kltm kltm modified the milestones: 2015-06-push, 2015-07-push Jun 30, 2015
@kltm
Copy link
Member Author

kltm commented Jul 14, 2015

Whoops, @hdietze still had "layout-hint-" and I was using "hint-layout-"--funs errors bubbled up (see: geneontology/minerva#6 (comment)).

@kltm
Copy link
Member Author

kltm commented Jul 14, 2015

@hdietze has fixed the upstream issues that were discovered during the fix of geneontology/minerva#6.

@kltm kltm closed this as completed in b8458df Jul 14, 2015
@kltm
Copy link
Member Author

kltm commented Jul 14, 2015

The solution for this is all in the client code--no special support on the sever except for the delicate handling of the "hint-layout-*" strings.

In the future, we could implement uniqueness on the server to make things a little easier on the client, but have not done so yet, and will not unless it becomes a frustration.

@kltm
Copy link
Member Author

kltm commented Jul 15, 2015

x/y coordinate mixup.

@kltm kltm reopened this Jul 15, 2015
@kltm kltm closed this as completed in 206dcc1 Jul 15, 2015
kltm added a commit to berkeleybop/bbopx-js that referenced this issue Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant