-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read (and use) node position annotations from stored in the Minerva models #113
Comments
My initial guess is to have the clients read these directly and only update Barista's during movement (which should be the default anyways). |
The three parts of correct handling. Reading
Use
Writing
|
Whoops, @hdietze still had "layout-hint-" and I was using "hint-layout-"--funs errors bubbled up (see: geneontology/minerva#6 (comment)). |
@hdietze has fixed the upstream issues that were discovered during the fix of geneontology/minerva#6. |
The solution for this is all in the client code--no special support on the sever except for the delicate handling of the "hint-layout-*" strings. In the future, we could implement uniqueness on the server to make things a little easier on the client, but have not done so yet, and will not unless it becomes a frustration. |
x/y coordinate mixup. |
@hdietze has recently exposed "layout-hint-x" and "layout-hint-y" as per-node annotations that can be round-tripped for experimentation.
We'll play with these and see how they work.
In the end, I suspect that we'll have "hint-layout-x", etc., as per-model meta.
The text was updated successfully, but these errors were encountered: