Skip to content
This repository has been archived by the owner on Sep 21, 2022. It is now read-only.

fix: notice about deprecated option replacement #957

Merged
merged 1 commit into from
Jan 30, 2019
Merged

fix: notice about deprecated option replacement #957

merged 1 commit into from
Jan 30, 2019

Conversation

sipayRT
Copy link
Member

@sipayRT sipayRT commented Jan 28, 2019

fix #956

@sipayRT
Copy link
Member Author

sipayRT commented Jan 28, 2019

//cc @DudaGod @rostik404

DudaGod
DudaGod approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@DudaGod DudaGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok

lib/cli/deprecations.js
@@ -31,8 +31,7 @@ function checkForRemovedOptions() {
_.forEach(REMOVED_OPTIONS_REPLACEMENTS, function(replacement, option) {
if (_.includes(process.argv, option)) {
throw new GeminiError(
util.format('Option %s is removed', option),
'Instead use ' + replacement
util.format('Option %s is removed. Instead use %s', option, replacement)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

чего сразу на template strings не перепишешь?

@sipayRT sipayRT merged commit 740edcd into master Jan 30, 2019
@sipayRT sipayRT deleted the sipayRT.deprecatedOptions branch January 30, 2019 10:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DudaGod DudaGod DudaGod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI deprecation error don't output replacement options
2 participants
@sipayRT @DudaGod