This repository has been archived by the owner on Sep 21, 2022. It is now read-only.
feat: set default browser orientation before each test #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sipayRT
approved these changes
Aug 14, 2018
| describe('orientation', function() { | ||
| it('should be null by default', function() { | ||
| var config = createBrowserConfig({ | ||
| httpTimeout: 1000 |
There was a problem hiding this comment.
косяк копипасты, поправлю.
| assert.equal(config.orientation, 'landscape'); | ||
| }); | ||
|
|
||
| it('should not accept any other value', function() { |
| return launchBrowser().then(() => assert.calledWith(wd.setOrientation, 'portrait')); | ||
| }); | ||
|
|
||
| it('should do nothing if no value is specified', () => { |
There was a problem hiding this comment.
я бы сначала проверил, что по дефолту ориентация не меняется (и без delete browser.config.orientation), а потом бы только проверил, что значение пробрасывается
There was a problem hiding this comment.
тогда будет важен порядок выполнения тестов, что не ок.
Flackus
commented
Aug 14, 2018
| return launchBrowser().then(() => assert.calledWith(wd.setOrientation, 'portrait')); | ||
| }); | ||
|
|
||
| it('should do nothing if no value is specified', () => { |
There was a problem hiding this comment.
тогда будет важен порядок выполнения тестов, что не ок.
| describe('orientation', function() { | ||
| it('should be null by default', function() { | ||
| var config = createBrowserConfig({ | ||
| httpTimeout: 1000 |
There was a problem hiding this comment.
косяк копипасты, поправлю.
| assert.equal(config.orientation, 'landscape'); | ||
| }); | ||
|
|
||
| it('should not accept any other value', function() { |
Flackus
force-pushed
the
feat/default-orientation
branch
from
bd9b6fd to
8348d7a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current solution for restoring orientation may fail – namely, when test times out. Setting orientation before the test run seems more reliable.
Frankly, we should also remove restoring orientation in
postActionswhen the related option is configured, but that can lead to some unfortunate consequences – as all projects can't be updated simultaneously – device may occur in unexpected state. Before doing so, runner should be updated and default orientation should be set in all projects. Just making these changes major do not make the transition easier.Point for discussion – should
geminithrow when trying to set default orientation for browser which has no such capability.