Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support RubyGems 2.3.x and earlier #428

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Drop support RubyGems 2.3.x and earlier #428

merged 1 commit into from
Jun 28, 2022

Conversation

tnir
Copy link
Member

@tnir tnir commented Jun 25, 2022 •
edited
Loading

Set required_rubygems_version to => 2.4.0 in gemspec. RubyGems 2.4.x is the default gem of Ruby 2.2.x (the oldest supported Ruby version) (see https://stdgems.org/2.2.0/).

As RubyGems 2.4.x, 2.5.0, and 2.5.1 does not support gem yank --host (rubygems/rubygems#1361), tests added in this PR are with RubyGems 2.5.2.

Tests using gem yank CLI are always failing with RubyGems 2.4.x as follows:

$ bundle exec rake

[...]

Finished in 25.657103s, 1.0523 runs/s, 3.7417 assertions/s.
  1) Failure:
GemcutterApiYankTest#test_method: can yank example  [/home/runner/work/geminabox/geminabox/test/test_support/geminabox_test_case.rb:76]:
Gemfile in data dir.
27 runs, 96 assertions, 1 failures, 0 errors, 0 skips
rake aborted!
Command failed with status (1)

https://github.com/geminabox/geminabox/runs/7083936756?check_suite_focus=true

Closes #427 and #424

Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com

@tnir tnir self-assigned this Jun 25, 2022
@tnir tnir marked this pull request as ready for review June 25, 2022 01:12
@tnir tnir modified the milestones: v2.0.0, Backlog, v3.0.0 Jun 25, 2022
@skaes
Copy link
Contributor

skaes commented Jun 27, 2022

My suggestion would be to stop testing all old and insecure rubies and only test the latest releases of 2.7.x, 3.0.x and 3.1.x.

@skaes
Copy link
Contributor

skaes commented Jun 27, 2022

As far as I understand, the only reason to test all those versions in the first place is the Geminabox gem plugin. I have personally never used it, as one can always use gem push with a host or even a simple curl command.

@ahorek
Copy link
Contributor

ahorek commented Jun 27, 2022

I agree with @skaes . All rubies between 2.2 - 2.6 are already EOL https://www.ruby-lang.org/en/downloads/branches/
a major release like 2.0.0 sounds like a good time to do some housekeeping

@tnir tnir force-pushed the tnir-rubygems-2.4.0-427 branch 3 times, most recently from f375639 to 54695b7 Compare June 28, 2022 00:42
@tnir tnir modified the milestones: v3.0.0, v2.1.0 Jun 28, 2022
@tnir
Drop support RubyGems 2.3.x and earlier
79efda5 
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@tnir tnir force-pushed the tnir-rubygems-2.4.0-427 branch from 54695b7 to 79efda5 Compare June 28, 2022 02:02
@tnir tnir enabled auto-merge (squash) June 28, 2022 02:03
@tnir
Copy link
Member Author

tnir commented Jun 28, 2022

@skaes @ahorek Totally I agree with you. I did it a lot in other projects and will do it in weeks.

@tnir tnir merged commit cb6cac9 into geminabox:master Jun 28, 2022
This was referenced Jun 28, 2022
Closed
Merged
@tnir tnir deleted the tnir-rubygems-2.4.0-427 branch June 28, 2022 03:04
@skaes skaes mentioned this pull request Jun 28, 2022
Closed
This was referenced Jun 28, 2022
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tnir tnir

Labels
Maintenance
Projects
Refactoring
Status: Done
Underlying Ruby/RubyGems: version skew
Status: No status
maintainer month 2022
Status: ✅ Done
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

Drop support for RubyGems before 2.4.0
3 participants
@tnir @skaes @ahorek