[Bugfix] Fix for incorrect output labels from ml.rf_to_strings workflow
#545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… indices not labels
…rnal construction of output values
|
Looks good. Thanks for fixing the bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains as a bug fix to correctly label the classification results when serializing a random forest model to strings for later use on EE. This also contains some support to infer output mode of the user provided classifier as well as allow users to explicitly define the output mode (used when assigning the correct output labels).
Changes:
ml.py: updated value labels to be gathered from sklearn classifier and added checks for output modeExample usage:
Closes #528