-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix several bugs and add basemap selector to core. #1735
Conversation
🚀 Deployed on https://6514f8cf1cde0744a6c8b3c4--opengeos.netlify.app |
Never mind. I figured it out. I am on a travel laptop. Forgot to use |
Just discovered another bug. The Screen.Recording.2023-09-27.at.11.16.27.PM.mov |
geemap/core.py
Outdated
ipyleaflet.TileLayer( | ||
url=basemap["url"], | ||
name=basemap["name"], | ||
max_zoom=basemap.get("max_zoom", 22), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recommend minimum max zoom 24
This seems an unexpect behavior (or maybe a bug) of ipyleaflet. When there is only one layer on the map, import ipyleaflet
m = ipyleaflet.Map(center=(0, 0), zoom=2)
m.remove_layer(m.layers[0]) # not working
m.clear_layers() # working |
Thanks for finding these issues. Looking into them now. |
Thanks for the quick fix. It works now. |
The basemap selector for geemap should be unchanged.
The basemap selector for core actually swaps out
layer[0]
. Users can manually add additional basemap layers if they choose.