Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added community datasets and improved GUI #1197

Merged
merged 5 commits into from
Aug 10, 2022

Conversation

karelvancamp
Copy link
Contributor

image

Search for multiple keywords works as AND filter. (so looking for 'CAMS' and 'fire' will result in empty list as no collection has both. If other behaviour is preferable, easy this in common.py

assets = reduce(set.intersection, assets)

To restrict gui to ee collections in geemap.py

ee_assets = search_ee_data(text.value, source='all')

@giswqs
Copy link
Member

giswqs commented Aug 10, 2022

This is awesome! They are several typos that need to be fixed.

image

@giswqs giswqs merged commit a5f369f into gee-community:master Aug 10, 2022
@karelvancamp
Copy link
Contributor Author

Thanks.

Do you think it could be feasible to use JS to python extractor for examples?
They often contain metrics and graphs.

@giswqs
Copy link
Member

giswqs commented Aug 10, 2022

Could you be more specific? I am not sure what you meant.

@giswqs
Copy link
Member

giswqs commented Aug 10, 2022

It seems sth is missing. Searching for elevation used to return a much longer list than this.

Screenshot_20220810_114700

@giswqs
Copy link
Member

giswqs commented Aug 10, 2022

The previous elevation list

Peek 2022-08-10 11-51

@karelvancamp
Copy link
Contributor Author

Ok, will check.

@karelvancamp
Copy link
Contributor Author

99% certain it's due to filtering on type of dataset.

Without it:

len(cm.search_ee_data('elevation')) == 49

Copy link
Contributor Author

@karelvancamp karelvancamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR ready

r= requests.get(link)
catalog_list = r.json()
matches += [search_collection(pattern, x) for x in catalog_list]
return [x for x in matches if x and x['type'] in types]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1197 due to filter on type of dataset

@karelvancamp
Copy link
Contributor Author

karelvancamp commented Aug 10, 2022

Do you think it could be feasible to use JS to python extractor for examples?
They often contain metrics and graphs.

There is a convertor.
image

I could scrape relevant code from example link code. Do you think the convertor has a good chance in general to generate valid python code based on de google earth engine examples & user code?

image

PS: also fixed sort of dataset names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants