Fix for custom tasks #105
Closed
Fix for custom tasks #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Team, please review and let me know if this is okay. I am navigating around to add a test in here somewhere. Is there a specific place you would like for me to put them? |
Closed
|
Thanks for your work on this. I will test this better before merging it in this time ;) |
|
No problem. Yeah, definitely should have tests before merging :) I'll work on that in a bit. At work now. |
|
+1 |
1 similar comment
|
+1 |
This was referenced Feb 22, 2015
drublic
added a commit
that referenced
this pull request
Feb 22, 2015
drublic
pushed a commit
that referenced
this pull request
Feb 22, 2015
jlescot
added a commit
to AirVantage/node-tech-mail
that referenced
this pull request
Aug 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes:
runTasksreturns a promise like all other methods