Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding touchpad controls for send-events #251

Merged
merged 12 commits into from
Oct 1, 2024

Conversation

jcamposz
Copy link
Contributor

@jcamposz jcamposz commented Jul 6, 2024

This pull request implements #224 .

@jcamposz
Copy link
Contributor Author

Updated UI according your proposal
imatge

@realmazharhussain
Copy link
Member

realmazharhussain commented Jul 13, 2024

"Enable Send events" is very cryptic.

Let me clarify what I meant in my previous comment.

  1. The title of the first preference should simply be just "Enable".
  2. The second preference should have a subtitle, and that subtitle should be "Disable the touchpad when an external mouse is connected".
  3. These two preferences should be at the very top of the touchpad section.

I also have some additional notes.

  1. The two preferences should not need to be nested.
  2. Now that I think of it, we should probably make the first toggle, a suffix of the touchpad section, instead of it having its own row, like they do for Bluetooth in GNOME Settings.
    image

@realmazharhussain
Copy link
Member

@jcamposz Are you still working on this, or is the PR abandoned?

@jcamposz
Copy link
Contributor Author

jcamposz commented Sep 8, 2024 via email

@jcamposz
Copy link
Contributor Author

jcamposz commented Sep 29, 2024

are you talking about something like this??
imatge
One question: if we click on the suffix , should the touchpad section disappear as Bluetooth page or only disabled??

@realmazharhussain
Copy link
Member

are you talking about something like this??
imatge

Yes, exactly (except "disable on external mouse" & "disable when typing" should be the top (1st) preferences in the touchpad section).

One question: if we click on the suffix , should the touchpad section disappear as Bluetooth page or only disabled??

I think disabling would be better than disappearing.

@realmazharhussain realmazharhussain linked an issue Oct 1, 2024 that may be closed by this pull request
Copy link
Member

@realmazharhussain realmazharhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this. ♥️

@realmazharhussain realmazharhussain merged commit abc4853 into gdm-settings:main Oct 1, 2024
@realmazharhussain
Copy link
Member

Please, provide your open collective username so that I can transfer you a $30 reward for the PR.

@jcamposz
Copy link
Contributor Author

jcamposz commented Oct 2, 2024

Hello @realmazharhussain . First of all, thanks. I have just created an account in open collective, my user-name, i think is: juan-campos. My email is: juan.camposzambrana@gmail.com

@realmazharhussain
Copy link
Member

It seems like I can't create a new "expense" on your behalf, but I can create a draft for you. So, I've done that and sent an invite to you. The expense is linked here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to disable touchpad on external mouse
2 participants