Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add bookmark folder to Block list of words for Vomnibar does not work #824

Closed
S-Aarab opened this issue Dec 11, 2022 · 2 comments
Closed

add bookmark folder to Block list of words for Vomnibar does not work #824

S-Aarab opened this issue Dec 11, 2022 · 2 comments
Labels
bug

Comments

@S-Aarab
Copy link

S-Aarab commented Dec 11, 2022 •
edited
Loading

Describtion

adding a folder to Block list of words for Vomnibar does not work in a new started firefox enless we modifie the block list and save the changes

Steps to reproduce the behavior:

  1. create a bookmarks folder e.g: hidden and add some bookmarks to it e.g: https://github.com/gdh1995/vimium-c
  2. add /hidden to the block list of words for vomnibar
  3. restart firefox or just disable/enable vimium-c
  4. launch vomnibar and search for one of the bookmarks that you added to the /hidden forlder e.g: gdh
  5. the bookmark shows in the result despite being in the folder /hidden
  6. now make any change to the block list (just add empty line or comment)
  7. do the search again, and the bookmark wont be in the result as expected
  8. if you restarted firefox or disable/enable vimium-c the ploblem comes back again

Browser, OS and Vimium C versions

  • Browser name: Firefox
  • Browser version: 107.0.1
  • Vimium C version: 1.99.96
  • OS name and version: Archlinux
@gdh1995
Copy link
Owner

gdh1995 commented Dec 18, 2022

Confirmed. I'll fix it then.

gdh1995 added a commit that referenced this issue Dec 22, 2022
@gdh1995
fix found issues
5771021 
* #825: should not log if disabled
* #824: add bookmark folder to Block list of words for Vomnibar does not work
* #823: dispatchEvent fails in v1.99.96
* some commands can not show tips on an old current page
@S-Aarab
Copy link
Author

S-Aarab commented Dec 23, 2022

I can confirme that version 1.99.97 solved the issue, thank you for the amazing work.

@S-Aarab S-Aarab closed this as completed Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gdh1995 @S-Aarab