Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vomnibar.activateTabSelection: Add filter current group and by group name options #671

Open
tinywrkb opened this issue Jun 26, 2022 · 7 comments
Open

Vomnibar.activateTabSelection: Add filter current group and by group name options #671

tinywrkb opened this issue Jun 26, 2022 · 7 comments
Labels
enhancement tab-groups
Milestone
manifest-v3

Comments

@tinywrkb
Copy link

The Vomnibar tabs selection mode is very handy is when working in fullscreen mode.
I think it could be even better if there was an option to only list tabs from the current active tabs group.
I looked in front/vomnibar.ts and I didn't find anything relevant.

Another suggestion, which I'm not even sure if it's possible to implement, is to filter tabs by group name.

The user will set a couple of group names in the mapping like this:

# tabs from current window
map t Vomnibar.activateTabSelection currentWindow 

# tabs from current group
map Tg Vomnibar.activateTabSelection group 

# tabs from "Reading" group
map Tr Vomnibar.activateTabSelection group="Reading"

# tabs from "Social" group
map Ts Vomnibar.activateTabSelection group="Social"

...
@gdh1995
Copy link
Owner

gdh1995 commented Jun 26, 2022

Up to now there's no filter in Vomnibar to only show tabs in a same group.

Detailed logic about tab matching is in

vimium-c/background/completion.ts

Line 464 in 8a2c08f

performSearch_ (this: void, query: CompletersNS.QueryStatus, tabs0: readonly WritableTabEx[]): void {
.

Browsers like Chrome and Firefox doesn't allow extensions to access group names, unless an extension is upgraded into "Manifest V3". So, because Vimium C is still in Manifest V2, the new feature is impossible to implement.

There has been a plan to upgrade Vimium C to Manifest V3 in up to 1 year. But I have no enough rest time to perfectly do such big changes.

@gdh1995 gdh1995 added this to the manifest-v3 milestone Jun 26, 2022
@gdh1995
Copy link
Owner

gdh1995 commented Jun 26, 2022

As for the 1st point, I'll add a feature, so that when a query contains a word of :group, and a current tab has been in a group, Vimium C will only show tabs in a same group (In Manifest V2 extensions are allowed to access group IDs).

gdh1995 added a commit that referenced this issue Jun 26, 2022
@gdh1995
add :group for #671
d1fb124
@tinywrkb
Copy link
Author

add :group for #671

Amazing! Looking forward to the next release. Thanks!

@tinywrkb tinywrkb changed the title Vomnibar.activateTabSelection: Add filter current group option Vomnibar.activateTabSelection: Add filter current group and by group name options Jun 29, 2022
@tinywrkb
Copy link
Author

Considering that this is in the manifest-v3, I updated the title here to also mention the group name.

@gdh1995
Copy link
Owner

gdh1995 commented Aug 11, 2022 •
edited
Loading

Hello, v1.99.0 supports the :group filter, and it has been available on Chrome and Firefox, while the version for MS Edge is waiting for reviews.

@tinywrkb
Copy link
Author

The Edge extension was updated today, and after a quick trial and error, the only way I found to map the :group filter is using the url option like the following.

map Tg Vomnibar.activateTabSelection url=":group"

@gdh1995
Copy link
Owner

gdh1995 commented Aug 28, 2022

Um yes :group needs to be a part of query words. Sorry I forgot to mention it.

The "tab" completion engine uses ": + xxx" in query as special filters, including :audio (aka :audible), :muted, :unmuted, :incognito, :normal, :pinned, and :group.

@gdh1995 gdh1995 mentioned this issue Nov 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement tab-groups
Projects
None yet
Milestone
manifest-v3
Development

No branches or pull requests
2 participants
@gdh1995 @tinywrkb