Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goPrevious/goNext should not scroll to the element #608

Closed
amosbird opened this issue Apr 20, 2022 · 4 comments
Closed

goPrevious/goNext should not scroll to the element #608

amosbird opened this issue Apr 20, 2022 · 4 comments
Labels
enhancement

Comments

@amosbird
Copy link

It's a common case to navigate back and forth with goPrevious/goNext command. Current behavior triggers a page scroll to expose the related element, which lead to unpleasant focus drifting.
@gdh1995
Copy link
Owner

gdh1995 commented Apr 20, 2022

accepted.

gdh1995 added a commit that referenced this issue Apr 24, 2022
@gdh1995
add some command parameters
a5b9311 
* LinkHints: copy .richText: now can copy an image
  * for #612
* restoreTab: add currentWindow on Firefox
  * on Chrome, Session.Tab.windowId is always 0
  * for #611
* goNext: add `view=false` to avoid scrolling
  * for #608
@amosbird
Copy link
Author

I noticed that commit a5b9311 has addressed this FR and the latest release seems to have it. However, map <c-f> goNext view=false still scrolls when pressing C-f to jump next page.

@gdh1995
Copy link
Owner

gdh1995 commented Jun 26, 2022

When I test the mapping on https://github.com/gdh1995/vimium-c/issues , <c-f> won't scroll the page.

So what's your test URL? Maybe the page scrolls itself when Vimium C clicks its next-page button.

I can add a new option to prefer replacing page URL directly to clicking an element if possible.

@amosbird
Copy link
Author

When I test the mapping on https://github.com/gdh1995/vimium-c/issues , won't scroll the page.

Yeah, this page works as expected.

So what's your test URL?

It's from some private resource. The feature is good enough for daily usage. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amosbird @gdh1995