-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Precise scrolling with scrollPxDown/Up #518
Comments
Up to now, all
It's a bit strange. This means your keyboard has a much smaller delay than Please note that
You may turn of "smooth scrolling" in a single key mapping, and it will be like:
BTW, in "smooth scrolling" mode and when a new Maybe I can add another option to ignore "repeated" events which looks "too near", compared with 560ms, into a future version of Vimium C. |
Thank you! The page scrolls precisely now.
Does this only apply with Am I correct in thinking I am content with smooth scrolling off though so no worries here. |
I think there's some issues in your browser itself - appearently it sent When |
Hello, Vimium C v1.96.0 has been released on Firefox Add-Ons, and you may add |
Thank you for the quick update! It works well for me now and is much more precise. I noticed there is still a bit of imprecision but not bad at all compared to before. It seems like the distance is determined by the length of the initial key tap. It will scroll half a page plus up to maybe 5 extra pixels depending on length of press. I tried to add a video but it said the mp4 was corrupt so I will try and figure that out. I am very happy with the way it is now though, I thought I would just let you know. Feel free to close or if you want to get to the bottom of it I can give you any info you need. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Hello every one. |
I noticed that when I define e.g. I'm not sure that's the same as what the original author described. But it got me a little confused. |
it works as expected. Vimium C will reduce/increase scrolling speed to near 150pixels per "duration" (about 120ms).
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Is there a way to change these variables? |
Update: the
@hasufell Up to now there's no way to change the logic. It seems good enough - there're few complaints about this in the origin project, Vimium (see https://github.com/philc/vimium/issues). For others, there seems indeed a logic issue which may make Vimium C scroll longer. I'll try to fix it. The root cause is the logic doesn't use |
Hello all, Vimium C v1.96.6 has been available on Firefox Add-Ons and Chrome Web Store. Its updates about scrolling are:
|
Hello Vimium C v1.97.0 has been published on Firefox Add-ons, and it tries to guess monitor refreshing rate (FPS) to generate scrolling steps. I'm closing this issue. If any new problem is found, fell free to reopen it. |
I've experienced since today (7 June, 2022) a drastic change in how smooth scrolling works on both Brave and Chrome - I don't know how frequently Chrome updates extensions, but the most recent update since I've noticed the change in behaviour is here (5 June, 2022): 554f1b1 I don't recall any OS updates between using my computer yesterday and today. I'm not sure if an update in Vimium C enabled smooth scroll for me in both browsers or not. ObservationsBefore:
After:
Setting Trying to press ScreencastLoom.Message.-.7.June.2022.mp4SettingsOS: Display: Vimium Settings: vimium_c-20220607_112046.json.zip WorkaroundDisabling smooth scroll restores the previous scroll behaviour for me |
Sorry I'll test it today. |
I am also experiencing the issue mentioned by @larrybotha. For me, on my 4k external monitor, everything feels the same as before. However on my MacBook Pro's built-in screen (16-inch M1 MacBook Pro) scrolling looks just like @larrybotha's screencast and the workaround (disabling smooth scrolling) works. |
@larrybotha @jaywonchung Thanks for your report. I've found the root cause and made a new unstable version to fix it and the bug of The root bug is Vimium C tries to guess screen refresh rate, but the logic is wrong when FPS is between 95 and 149. And this explains why it still works correctly on a 4k + 30/60fps monitor. In the web-store version of v1.98.1, there're a trick to force Vimium C not to guess FPS:
This trick is not perfect - it may fail if you hold on a key to scroll longer. And when v1.98.2 is updated, please remove the |
@gdh1995 excellent, thanks for all the hard work Smooth scrolling is working with the additional keyboard config - I see the sensitivity to the duration of a key press. Thanks again, looking forward to the 1.98.2 release |
Upgraded to v1.98.2, and things work perfectly. Thanks a lot!! |
Librewolf 94.0.2 with Vimium-C 1.95.0 on Arch Linux 5.15.6
Scrolling with the commands scrollDown/Up, scrollPxDown/Up, and scrollPageDown/Up all have the behavior that the scroll length is dependent upon how long I hold the key down. This is expected behavior if you hold the key for above the delay duration but my keyboard delay/repeat setting is [560, 33] and even when I barely tap the button I am getting inconsistent scroll length.
I think this behavior is good for scrollDown/Up, as you want it to be responsive, but for scrollPageDown/Up and scrollPxDown/Up it would be nice if the movements were precisely half a page/set pixel amount respectively. Even if just scrollPxDown/Up were precise, you could scale the pixel amount and remap u/d to be exactly half a page, and leave scrollPageDown/Up alone.
I have tried disabling privacy.resistFingerPrinting in about:config thinking the inconsistent time-steps might've been affecting it with no change.
This would really help as precise scrolling would help me maintain visual context, and since I would like to keep resistFingerPrinting on, I cannot use the more responsive scrollDown/Up commands.
Here are the mapping commands I tried in case I messed them up:
Many thanks for the sweet plugin. I can provide any more info if necessary.
The text was updated successfully, but these errors were encountered: