-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox: pressing 't' does not open new tab #51
Comments
Are you downloading Vimium C from Chrome Web Store or Firefox Add-ons?
…---Original---
From: "Son Luong Ngoc"<notifications@github.com>
Date: Mon, Jun 24, 2019 19:58 PM
To: "gdh1995/vimium-c"<vimium-c@noreply.github.com>;
Cc: "Subscribed"<subscribed@noreply.github.com>;
Subject: [gdh1995/vimium-c] Firefox: pressing 't' does not open new tab (#51)
Version tested
1.75.7 Firefox Nightly
1.75.7 Vimium-c Chrome stable
What did you do
Open browser
Open google.com
Press 't' to open new tab
Expected result
Browser open a new tab
Actual result
Firefox does not open new tab
Chrome does open a new tab
Note
Every other features are still working normally on firefox (o, b, j, k, f, ...)
CMD + t still work as hotkey to open new tab
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Tested with Vimium C master (BTypes = Firefox) on Firefox 69.0a1 (64-bit, Win 10), I can not reproduce it. What's your settings of "New tab URL"? Maybe recent Firefox disables more URLs - as far as I know, Vimium C can not create a tab of Reference of |
The reason that I asked the version of Vimium C is you said this in this issue:
A strange bug. I once tested those URLs and I'll do more tests on latest Firefox in days. |
Confirmed as a bug, and 7eabcc5 should fix it. I'll publish a new version in days. |
v1.75.8 has been released on Firefox Add-ons. You may have a try. |
I am on 1.75.8 right now and can confirm that I can use 't' However when open a new tab (firefox) with 't' or Cmd + T, the url bar is filled instead of being empty
|
Um... You're right, But, the fact is that Firefox has "too strict" limitation on URLs that web-extensions want to open, and The URL in address bar is because:
There have been so many discussions and complaints about Vimium C's behavior of overriding New Tab, so I've planned to split this feature into another web-extension (Some discussions in Chineses may be seen in #47). It will be in Vimium C v1.76.*** or v1.77. |
Complain tickets on Extension limitation on URL bar for Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1409675 Possible solution (WIP) ticket: https://bugzilla.mozilla.org/show_bug.cgi?id=1460412 |
@gdh1995 I am using 1.77.2 on Firefox and am still having this issue. I thought this might have been fixed in 1.77 since new tab is no longer being managed, but |
Some URLs are refused by Firefox to open from an extension. So what's your chosen NewTab on Vimium C Options page? |
It's the default about:newtab. |
@meluskyc Vimium C v1.77.3 has been released on Firefox Add-ons, and you may try it again. There's a hidden logic bug and it was exposed in v1.77.0, because of not managing browser's NewTab. |
Fixed. Thank you! |
Version tested
What did you do
google.com
Expected result
Actual result
Note
Every other features are still working normally on firefox (o, b, j, k, f, ...)
CMD + t still work as hotkey to open new tab
The text was updated successfully, but these errors were encountered: